kenobi/jellyfin-discord-bot
2
1
Fork 0
Code Issues 17 Pull Requests 1 Actions Packages Projects 1 Releases Wiki Activity

feat/40-reroll-on-disinterest #54

Merged
kenobi merged 73 commits from feat/40-reroll-on-disinterest into master 2023-11-19 20:24:36 +01:00
Conversation 2 Commits 73 Files Changed 23 +3
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5a6c66cb3e - Show all commits

3
server/logger.ts
View File

@ -1,5 +1,8 @@
import { createLogger, format, transports } from "winston"
import { config } from "./configuration"
import { v4 } from "uuid"
export const newRequestId = v4()
magnetotail marked this conversation as resolved Outdated
magnetotail commented 2023-06-27 18:45:35 +02:00
Outdated
Review
Copy Link

why?

why?
kenobi commented 2023-06-27 20:19:19 +02:00
Outdated
Review
Copy Link

This is a complete and total, boneheaded error :D
The intention was to present an more memorizable way to get a new uuid/v4.
Instead this just sets it once, making it useless.
It should be an exported function, returning the output of v4() and the callsite would be
const requestId = newRequestId()
This would prevent the
import { v4 as uuid } from "uuid" or const requestId = v4() which, I think, are tedious or non-obvious.
If you think this is a bad idea, I will gladly revert it though :)

This is a complete and total, boneheaded error :D The _intention_ was to present an more memorizable way to get a new uuid/v4. Instead this just sets it once, making it useless. It _should_ be an exported function, returning the output of `v4()` and the callsite would be `const requestId = newRequestId()` This would prevent the `import { v4 as uuid } from "uuid"` or `const requestId = v4()` which, I think, are tedious or non-obvious. If you think this is a bad idea, I will gladly revert it though :)
magnetotail commented 2023-06-27 20:24:01 +02:00
Outdated
Review
Copy Link

I dont think it's bad tbh if we dont need the v4 as uuid import then. But I would also like an eventhandler framework where we would prevent usual boilerplate code like looking for guild Id or making a request id and put those base checks and things in a base class and just have handling code in a subclass. But that is quite hard as I learned

I dont think it's bad tbh if we dont need the v4 as uuid import then. But I would also like an eventhandler framework where we would prevent usual boilerplate code like looking for guild Id or making a request id and put those base checks and things in a base class and just have handling code in a subclass. But that is quite hard as I learned
export const noGuildId = 'NoGuildId'
const printFn = format.printf(({ guildId, level, message, errorCode, requestId, timestamp: logTimestamp }: { [k: string]: string }) => {