kenobi/jellyfin-discord-bot
2
1
Fork 0
Code Issues 17 Pull Requests 1 Actions Packages Projects 1 Releases Wiki Activity

feat/40-reroll-on-disinterest #54

Merged
kenobi merged 73 commits from feat/40-reroll-on-disinterest into master 2023-11-19 20:24:36 +01:00
Conversation 2 Commits 73 Files Changed 23 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a455fd8ff7 - Show all commits

4
server/helper/vote.controller.ts
View File

@ -92,7 +92,7 @@ export default class VoteController {
// create new message
magnetotail marked this conversation as resolved Outdated
magnetotail commented 2023-11-18 12:56:46 +01:00
Outdated
Review
Copy Link

is not a message, only messagetext

is not a message, only messagetext
kenobi commented 2023-11-18 18:16:05 +01:00
Outdated
Review
Copy Link

a455fd8ff7

a455fd8ff7e6b8ffb032fb4aed9389da68ee513b
kenobi commented 2023-11-18 18:28:17 +01:00
Outdated
Review
Copy Link

done

done
logger.info(`Creating new poll message with new movies: ${movies}`, { requestId, guildId })
const message = this.createVoteMessageText(voteInfo.eventId, voteInfo.eventDate, movies, guildId, requestId)
const messageText = this.createVoteMessageText(voteInfo.eventId, voteInfo.eventDate, movies, guildId, requestId)
const announcementChannel = this.client.getAnnouncementChannelForGuild(guildId)
if (!announcementChannel) {
logger.error(`No announcementChannel found for ${guildId}, can't post poll`)
@ -106,7 +106,7 @@ export default class VoteController {
logger.error(`Error during removeMessage: ${err}`)
}
magnetotail marked this conversation as resolved Outdated
magnetotail commented 2023-11-18 13:00:17 +01:00
Outdated
Review
Copy Link

why not pin message in method above?

why not pin message in method above?
kenobi commented 2023-11-19 20:06:35 +01:00
Outdated
Review
Copy Link

7d794a8001
should have been moved to prepareAndSendVoteMessage()

7d794a8001a66d068f949c893d689a068c3caeed should have been moved to prepareAndSendVoteMessage()
const sentMessage = await this.sendVoteMessage(message, movies.length, announcementChannel)
const sentMessage = await this.sendVoteMessage(messageText, movies.length, announcementChannel)
sentMessage.pin()
logger.info(`Sent and pinned new poll message`, { requestId, guildId })
}