kenobi/jellyfin-discord-bot
2
1
Fork 0
Code Issues 17 Pull Requests 1 Actions Packages Projects 1 Releases Wiki Activity

feat/40-reroll-on-disinterest #54

Merged
kenobi merged 73 commits from feat/40-reroll-on-disinterest into master 2023-11-19 20:24:36 +01:00
Conversation 2 Commits 73 Files Changed 23 +10
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ee742018e9 - Show all commits

10
server/structures/client.ts
View File

@ -85,6 +85,16 @@ export class ExtendedClient extends Client {
logger.info(`Error refreshing slash commands: ${error}`)
}
}
/**
kenobi marked this conversation as resolved Outdated
magnetotail commented 2023-06-27 18:46:41 +02:00
Outdated
Review
Copy Link

why is this necessary?

why is this necessary?
kenobi commented 2023-06-27 20:08:07 +02:00
Outdated
Review
Copy Link

It's complicated. I put in some JSDoc comments:

	/**
		* Fetches all messages from the provided channel collection.
		* This is necessary for announcementChannels, because 'old' messages don't receive
		* messageReactionAdd Events, only messages that were sent while the bot is online are tracked
		* automatically.
		* To prevent the need for a dedicated 'Collector' implementation which would listen on specific
		* it's easiest to just fetch all messages from the backlog, which automatically makes the bot track them
		* again.
		* @param {Collection<string, TextChannel>} channels - All channels which should be fecthed for reactionTracking	
		*/
It's complicated. I put in some JSDoc comments: ```ts /** * Fetches all messages from the provided channel collection. * This is necessary for announcementChannels, because 'old' messages don't receive * messageReactionAdd Events, only messages that were sent while the bot is online are tracked * automatically. * To prevent the need for a dedicated 'Collector' implementation which would listen on specific * it's easiest to just fetch all messages from the backlog, which automatically makes the bot track them * again. * @param {Collection<string, TextChannel>} channels - All channels which should be fecthed for reactionTracking */ ```
magnetotail commented 2023-06-27 20:14:58 +02:00
Outdated
Review
Copy Link

Figured something like that. Thanks for the comment

Figured something like that. Thanks for the comment
* Fetches all messages from the provided channel collection.
* This is necessary for announcementChannels, because 'old' messages don't receive
* messageReactionAdd Events, only messages that were sent while the bot is online are tracked
* automatically.
* To prevent the need for a dedicated 'Collector' implementation which would listen on specific
* it's easiest to just fetch all messages from the backlog, which automatically makes the bot track them
* again.
* @param {Collection<string, TextChannel>} channels - All channels which should be fecthed for reactionTracking
*/
private async fetchAnnouncementChannelMessage(channels: Collection<string, TextChannel>): Promise<void> {
channels.each(async ch => {
ch.messages.fetch()