Sammy magnetotail
  • Joined on 2023-06-03
magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-11-18 12:59:41 +01:00
feat/40-reroll-on-disinterest

maybe extract this if-else to a method to keep code more compact

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-11-18 12:56:46 +01:00
feat/40-reroll-on-disinterest

is not a message, only messagetext

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-11-18 12:55:51 +01:00
feat/40-reroll-on-disinterest

threshold seems to be a magic number

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-11-18 12:54:45 +01:00
feat/40-reroll-on-disinterest

comment is misleading, voteinfo is also used to get the eventid and eventdate in line 93

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-11-18 12:53:00 +01:00
feat/40-reroll-on-disinterest

above WHAT threshold? What does it do??

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-11-18 12:51:15 +01:00
feat/40-reroll-on-disinterest

Parameter die eine Message sind heißen oft "message", manchmal aber auch "msg". sollte vereinheitlicht sein

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-11-18 12:45:57 +01:00
feat/40-reroll-on-disinterest

?

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-11-18 12:44:24 +01:00
feat/40-reroll-on-disinterest

Das pinnen sollte glaube ich auch nicht das event übernehmen sondern der Controller

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-11-18 12:43:06 +01:00
feat/40-reroll-on-disinterest

Warum erst eine message erstellen lassen die dann vom gleichen controller in der nächsten Zeile verschickt wird? Fände besser dem Controller zu sagen "Schick ne Vote message, hier sind die Infos die du brauchst"

magnetotail commented on issue kenobi/jellyfin-discord-bot#56 2023-07-14 23:21:23 +02:00
/propose Command

Find letzteres gut!

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-06-27 20:24:01 +02:00
feat/40-reroll-on-disinterest

I dont think it's bad tbh if we dont need the v4 as uuid import then. But I would also like an eventhandler framework where we would prevent usual boilerplate code like looking for guild Id or…

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-06-27 20:14:58 +02:00
feat/40-reroll-on-disinterest

Figured something like that. Thanks for the comment

magnetotail suggested changes for kenobi/jellyfin-discord-bot#54 2023-06-27 18:51:42 +02:00
feat/40-reroll-on-disinterest

Also linting warnings in some files because of unused imports

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-06-27 18:49:55 +02:00
feat/40-reroll-on-disinterest

Can this be integrated into Emoji? Maybe provide method to only get number emojis then? By definition "NONE_OF_THAT" is also an emoji

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-06-27 18:46:42 +02:00
feat/40-reroll-on-disinterest

why is this necessary?

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-06-27 18:45:35 +02:00
feat/40-reroll-on-disinterest

why?

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-06-27 18:44:28 +02:00
feat/40-reroll-on-disinterest

Would like an enum of message types and a method with input message and output array of message types for possible messages with multiple things.

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-06-27 18:41:36 +02:00
feat/40-reroll-on-disinterest

Rename file to something like "handleVoteReaction" to make it separate from future reactionadd handlers

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-06-27 18:40:30 +02:00
feat/40-reroll-on-disinterest

Move check to handleMessageReactionAdd

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54 2023-06-27 18:40:14 +02:00
feat/40-reroll-on-disinterest

duplicate check. already checked before call in handleMessageReactionAdd