kenobi/jellyfin-discord-bot
2
1
Fork 0
Code Issues 17 Pull Requests 1 Actions Packages Projects 1 Releases Wiki Activity

fix/movie_names_and_background_task #46

Merged
kenobi merged 5 commits from fix/movie_names_and_background_task into master 2023-06-19 11:29:04 +02:00
Conversation 2 Commits 5 Files Changed 5 +75 -59
magnetotail commented 2023-06-17 12:07:48 +02:00
Collaborator
Copy Link

Sieht nach viel aus, ist beim closepoll aber hauptsächlich durch die Gegend schieben

Sieht nach viel aus, ist beim closepoll aber hauptsächlich durch die Gegend schieben
magnetotail added 2 commits 2023-06-17 12:07:48 +02:00
improve movie name resolving
All checks were successful
Build a docker image for node-jellyfin-role-bot / build-docker-image (push) Successful in 1m55s
Details
d6300e8bec 
When creating the poll the bot will now only request movie names instead of movies
This improves the errorhandling because the movie names cannot be null
Also the movieName function filters empty movienames and will guarantee the requested number of names
move scheduling of pollclose task to startup
All checks were successful
Build a docker image for node-jellyfin-role-bot / build-docker-image (push) Successful in 1m37s
Details
07849d331a 
Also moved check function to closepoll.ts
magnetotail commented 2023-06-17 12:13:11 +02:00
Author
Collaborator
Copy Link

closes #24
closes #36

closes #24 closes #36
magnetotail requested review from kenobi 2023-06-17 12:39:58 +02:00
kenobi reviewed 2023-06-17 12:47:06 +02:00
server/commands/closepoll.ts Outdated
@ -148,0 +167,4 @@
const eventDate: Date = toDate(updatedEvent.scheduledStartTimestamp)
const closePollDate: Date = addDays(eventDate, -2)
if (isAfter(Date.now(), closePollDate)) {
kenobi commented 2023-06-17 12:46:58 +02:00
Owner
Copy Link

This would also meant that it is not possible to start an impromptu poll for a Watchparty 'tonight'.
Maybe it's possible to also check if the post is older than 24 hours?

This would also meant that it is not possible to start an impromptu poll for a Watchparty 'tonight'. Maybe it's possible to also check if the post is older than 24 hours?
magnetotail commented 2023-06-17 12:50:21 +02:00
Author
Collaborator
Copy Link

I think this would better be solved by !noautoclose or something when making the !nextwp? Could be carried to the voting offen event or the message to parse for that?

I think this would better be solved by !noautoclose or something when making the !nextwp? Could be carried to the voting offen event or the message to parse for that?
kenobi commented 2023-06-17 12:58:11 +02:00
Owner
Copy Link

This would increase 'friction' I feel.
An easy thing for users to forget to do and be surprised by how the bot acts.
I would propose that we could do both.
If the distance between poll post date and event date is less than 2 days it does not auto close, but the poll creation would need to be adjusted to contain guidance on how to close the poll manually for the creator of the event.
'Normal' poll posts would be made a week in advance to a watch party so the 2-day auto close would be fine.

This would increase 'friction' I feel. An easy thing for users to forget to do and be surprised by how the bot acts. I would propose that we could do both. If the distance between poll post date and event date is less than 2 days it does not auto close, but the poll creation would need to be adjusted to contain guidance on how to close the poll manually for the creator of the event. 'Normal' poll posts would be made a week in advance to a watch party so the 2-day auto close would be fine.
magnetotail commented 2023-06-17 13:19:34 +02:00
Author
Collaborator
Copy Link

Implemented check to see if less than or equal to two days between start and create date of event

Implemented check to see if less than or equal to two days between start and create date of event
kenobi marked this conversation as resolved
server/structures/client.ts Outdated
@ -170,2 +173,4 @@
task.stop()
}
private async startPollCloceBackgroundTasks() {
kenobi commented 2023-06-17 12:41:53 +02:00
Owner
Copy Link

startPollCloseBackgroundTask

startPollClo**s**eBackgroundTask
magnetotail commented 2023-06-17 13:04:00 +02:00
Author
Collaborator
Copy Link

fixed

fixed
kenobi marked this conversation as resolved
magnetotail added 1 commit 2023-06-17 13:03:56 +02:00
prevent poll close if event is less than 24h old
All checks were successful
Build a docker image for node-jellyfin-role-bot / build-docker-image (push) Successful in 1m15s
Details
4cc332820f
magnetotail added 1 commit 2023-06-17 13:19:41 +02:00
Check if less than 2 days between create and start for deciding if to close
All checks were successful
Build a docker image for node-jellyfin-role-bot / build-docker-image (push) Successful in 1m9s
Details
670a64af22
kenobi commented 2023-06-19 11:19:07 +02:00
Owner
Copy Link

looks good to me

looks good to me
kenobi added 1 commit 2023-06-19 11:19:20 +02:00
Merge branch 'master' into fix/movie_names_and_background_task
All checks were successful
Compile the repository / compile (push) Successful in 1m31s
Details
59f5b34e5a
kenobi merged commit 6d5725be90 into master 2023-06-19 11:29:04 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
kenobi
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
investigation

   
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
investigation
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kenobi/jellyfin-discord-bot#46
No description provided.
Delete Branch "fix/movie_names_and_background_task"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?