kenobi/jellyfin-discord-bot
2
1
Fork 0
Code Issues 17 Pull Requests 1 Actions Packages Projects 1 Releases Wiki Activity

fix/movie_names_and_background_task #46

Merged
kenobi merged 5 commits from fix/movie_names_and_background_task into master 2023-06-19 11:29:04 +02:00
Conversation 2 Commits 5 Files Changed 5 +10 -2
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 4cc332820f - Show all commits

8
server/commands/closepoll.ts
View File

@ -164,6 +164,14 @@ export async function checkForPollsToClose(guild: Guild): Promise<void> {
return
}
const createDate: Date = toDate(updatedEvent.createdTimestamp)
const closePollMinDate: Date = addDays(createDate, 1)
if(isAfter(closePollMinDate, Date.now())) {
kenobi marked this conversation as resolved Outdated
kenobi commented 2023-06-17 12:46:58 +02:00
Outdated
Review
Copy Link

This would also meant that it is not possible to start an impromptu poll for a Watchparty 'tonight'.
Maybe it's possible to also check if the post is older than 24 hours?

This would also meant that it is not possible to start an impromptu poll for a Watchparty 'tonight'. Maybe it's possible to also check if the post is older than 24 hours?
magnetotail commented 2023-06-17 12:50:21 +02:00
Outdated
Review
Copy Link

I think this would better be solved by !noautoclose or something when making the !nextwp? Could be carried to the voting offen event or the message to parse for that?

I think this would better be solved by !noautoclose or something when making the !nextwp? Could be carried to the voting offen event or the message to parse for that?
kenobi commented 2023-06-17 12:58:11 +02:00
Outdated
Review
Copy Link

This would increase 'friction' I feel.
An easy thing for users to forget to do and be surprised by how the bot acts.
I would propose that we could do both.
If the distance between poll post date and event date is less than 2 days it does not auto close, but the poll creation would need to be adjusted to contain guidance on how to close the poll manually for the creator of the event.
'Normal' poll posts would be made a week in advance to a watch party so the 2-day auto close would be fine.

This would increase 'friction' I feel. An easy thing for users to forget to do and be surprised by how the bot acts. I would propose that we could do both. If the distance between poll post date and event date is less than 2 days it does not auto close, but the poll creation would need to be adjusted to contain guidance on how to close the poll manually for the creator of the event. 'Normal' poll posts would be made a week in advance to a watch party so the 2-day auto close would be fine.
magnetotail commented 2023-06-17 13:19:34 +02:00
Outdated
Review
Copy Link

Implemented check to see if less than or equal to two days between start and create date of event

Implemented check to see if less than or equal to two days between start and create date of event
logger.info("Event is less than 24h old. Not closing poll!", { guildId: guild.id, requestId })
return
}
const eventDate: Date = toDate(updatedEvent.scheduledStartTimestamp)
const closePollDate: Date = addDays(eventDate, -2)

4
server/structures/client.ts
View File

@ -75,7 +75,7 @@ export class ExtendedClient extends Client {
this.cacheUsers(guilds)
await this.cacheAnnouncementServer(guilds)
this.startAnnouncementRoleBackgroundTask(guilds)
this.startPollCloceBackgroundTasks()
this.startPollCloseBackgroundTasks()
})
} catch (error) {
logger.info(`Error refreshing slash commands: ${error}`)
@ -173,7 +173,7 @@ export class ExtendedClient extends Client {
task.stop()
}
private async startPollCloceBackgroundTasks() {
private async startPollCloseBackgroundTasks() {
kenobi marked this conversation as resolved Outdated
kenobi commented 2023-06-17 12:41:53 +02:00
Outdated
Review
Copy Link

startPollCloseBackgroundTask

startPollClo**s**eBackgroundTask
magnetotail commented 2023-06-17 13:04:00 +02:00
Outdated
Review
Copy Link

fixed

fixed
for(const guild of this.guilds.cache) {
this.pollCloseBackgroundTasks.set(guild[1].id, schedule("0 * * * * *", () => checkForPollsToClose(guild[1])))
}