feat/#42_announce_manual_watchparty #50

magnetotail · 2023-06-23T15:57:21+02:00

magnetotail commented

2023-06-23 15:57:21 +02:00

closes #42 closes #30

magnetotail added 3 commits 2023-06-23 15:57:22 +02:00

Rename event files to specific case 5b98c9bf2f

We can add multiple eventhandlers per eventname. To avoid confusion and large files and to improve concise file names the event files were renamed

properly clean up wp announcements without event only 31e440434e

prevent announcement when description contains !private

Compile the repository / compile (pull_request) Successful in 1m43s

Details

45d87275bf

kenobi approved these changes 2023-06-23 19:27:17 +02:00

server/helper/dateHelper.ts Outdated

						
				@ -0,0 +5,4 @@

				export function createDateStringFromEvent(event: GuildScheduledEvent, requestId: string, guildId?: string): string {

				    if(!event.scheduledStartAt) {

				        logger.error("Event has no start. Cannot create dateString.", {guildId, requestId})

				        return "habe keinen Startzeitpunkt ermitteln können"

kenobi commented

2023-06-23 19:24:50 +02:00

Maybe put it in backticks or a different wording, otherwise it might read:
"Es gibt eine neue Abstimmung für die nächste Watchparty habe keinen Startzeitpunkt ermitteln können!"

Maybe put it in backticks or a different wording, otherwise it might read: "Es gibt eine neue Abstimmung für die nächste Watchparty habe keinen Startzeitpunkt ermitteln können!"

magnetotail added 1 commit 2023-06-23 19:30:26 +02:00

improve message clarity when no start date in event found

Compile the repository / compile (pull_request) Successful in 4m8s

Details

3a5ea5d4ff

magnetotail merged commit 2802afa7d5 into master

2023-06-23 19:31:58 +02:00

magnetotail referenced this issue from a commit

2023-06-23 19:31:59 +02:00

Merge pull request 'feat/#42_announce_manual_watchparty' (#50) from feat/#42_announce_manual_watchparty into master

Sign in to join this conversation.

No reviewers