WIP: feat/20-reactions-for-roles #59
		Reference in New Issue
	
	Block a user
	
	No description provided.
		
		Delete Branch "feat/20-reactions-for-roles"
	
	Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
solves #20
feat/20-reactions-for-rolesto WIP: feat/20-reactions-for-roles@ -0,0 +41,4 @@.catch(error => { logger.error(`Could not find announcement_role with id ${config.bot.announcement_role}. Error: ${error}`, { requestId, guildId: guild.id }) })}public async assignAnnouncementRolesFromReactions(guild: Guild, reaction: MessageReaction, requestId: string) {method called reactions but parameter is singular
1f372b0aac@ -0,0 +47,4 @@const announcementRole = await this.getAnnouncementRoleForGuild(guild, requestId)if (!announcementRole)throw new Error(`No announcementRole found in guild ${guildId}`)add error to previous line to be consistent with rest of class. Also maybe put checking to getAnnouncementRoleForGuild, so calling methods can rely on the role to be there?
a50ac1716f@ -2,3 +2,3 @@import { GuildScheduledEvent, Role, TextChannel } from "discord.js"export type Maybe<T> = T | undefined | nullexport type Maybe<T> = T | undefined | null | voidew, a THIRD "not there" type??? wth
a60fc2db7eNo longer necessary after refactoring of announcementrole fetching
a50ac1716fNice work only minor comments from me so far. Great to have a controller for roles now
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.