Sammy

magnetotail suggested changes for kenobi/jellyfin-discord-bot#59

2023-11-24 15:55:49 +01:00

WIP: feat/20-reactions-for-roles

Nice work only minor comments from me so far. Great to have a controller for roles now

magnetotail commented on pull request kenobi/jellyfin-discord-bot#59

2023-11-24 15:53:42 +01:00

WIP: feat/20-reactions-for-roles

ew, a THIRD "not there" type??? wth

magnetotail commented on pull request kenobi/jellyfin-discord-bot#59

2023-11-24 15:48:15 +01:00

WIP: feat/20-reactions-for-roles

add error to previous line to be consistent with rest of class

magnetotail commented on pull request kenobi/jellyfin-discord-bot#59

2023-11-24 15:47:36 +01:00

WIP: feat/20-reactions-for-roles

method called reactions but parameter is singular

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54

2023-11-19 20:21:48 +01:00

feat/40-reroll-on-disinterest

Emotes got renamed to validVoteEmotes

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54

2023-11-19 20:13:31 +01:00

feat/40-reroll-on-disinterest

renamed to getOpenPollEvent

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54

2023-11-18 16:33:23 +01:00

feat/40-reroll-on-disinterest

Or rename method to "hasAtLeastOneVote"

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54

2023-11-18 16:32:34 +01:00

feat/40-reroll-on-disinterest

Replace this do something with a meaningful todo

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54

2023-11-18 16:27:14 +01:00

feat/40-reroll-on-disinterest

Evtl halt über nen Parameter bestimmen. Auf lange Sicht gehört das eigentliche verschicken der Message eh in einen eigenen controller aber der voteController kann die Daten für eine voteMessage…

magnetotail suggested changes for kenobi/jellyfin-discord-bot#54

2023-11-18 13:39:48 +01:00

feat/40-reroll-on-disinterest

Kp, was man hier rein schreibt, hab n paar Dinge angemerkt

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54

2023-11-18 13:37:11 +01:00

feat/40-reroll-on-disinterest

rename parameter lastMessages to message. "last" seems to be very specific as a parameter, also false plural

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54

2023-11-18 13:36:15 +01:00

feat/40-reroll-on-disinterest

why plural?

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54

2023-11-18 13:35:32 +01:00

feat/40-reroll-on-disinterest

"Fehler, event hatte keine Uhrzeit" pls

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54

2023-11-18 13:34:25 +01:00

feat/40-reroll-on-disinterest

should be renamed so it's clear what the event gets updated with and what it looks like in the end and what kind of event gets updated (I guess open poll events)

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54

2023-11-18 13:31:14 +01:00

feat/40-reroll-on-disinterest

rename to "getOpenVoteEvent", since other events get filtered out

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54

2023-11-18 13:30:20 +01:00

feat/40-reroll-on-disinterest

cancelling uptade log seems wrong here

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54

2023-11-18 13:28:11 +01:00

feat/40-reroll-on-disinterest

remove todo

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54

2023-11-18 13:27:30 +01:00

feat/40-reroll-on-disinterest

rename message to messageText

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54

2023-11-18 13:01:58 +01:00

feat/40-reroll-on-disinterest

wtf :D

magnetotail commented on pull request kenobi/jellyfin-discord-bot#54

2023-11-18 13:00:17 +01:00

feat/40-reroll-on-disinterest

why not pin message in method above?